Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] ensure CI for python 3.8-3.10 runs on pandas 2 #4795

Merged
merged 1 commit into from Jul 4, 2023
Merged

[MNT] ensure CI for python 3.8-3.10 runs on pandas 2 #4795

merged 1 commit into from Jul 4, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jun 29, 2023 •
edited

Fixes #4794

This is done by removal of packages conflicting with pandas 2 from the dependency set that is tested.

The all_extras set does not change, instead a smaller all_extras_pandas2 is tested.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jun 29, 2023
@fkiraly fkiraly changed the title [MNT] ensure CI for 3.8-3.11 runs on pandas 2 [MNT] ensure CI for python 3.8-3.10 runs on pandas 2 Jun 29, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Jun 29, 2023

Works as expected - the python 3.8-3.10 CI now use pandas 2.0.3, while statsforecast is present and being tested on the pandas1 CI elements.

@fkiraly fkiraly merged commit 3e0a998 into main Jul 4, 2023
24 checks passed
@fkiraly fkiraly deleted the pandas2-ci branch July 4, 2023 13:13
@fkiraly fkiraly mentioned this pull request Jul 4, 2023
Merged
fkiraly added a commit that referenced this pull request Jul 4, 2023
@fkiraly
[MNT] also restrict tslearn on the pandas 2 testing dependency set (
8090725 
#4825)

Ensures that the addition in #4795
also has the bound from #4819
CTFallon pushed a commit to CTFallon/sktime that referenced this pull request Jul 5, 2023
@fkiraly @CTFallon
[MNT] ensure CI for python 3.8-3.10 runs on pandas 2 (sktime#4795)
e6b32ca 
Fixes sktime#4794

This is done by removal of packages conflicting with `pandas 2` from the
dependency set that is tested.

The `all_extras` set does not change, instead a smaller
`all_extras_pandas2` is tested.
CTFallon pushed a commit to CTFallon/sktime that referenced this pull request Jul 5, 2023
@fkiraly @CTFallon
[MNT] also restrict tslearn on the pandas 2 testing dependency set (
8aded21 
sktime#4825)

Ensures that the addition in sktime#4795
also has the bound from sktime#4819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] resolve pandas restriction to <2 in CI for 3.8-3.10
1 participant
@fkiraly