Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] fix typos in forecasting module #5314

Merged
merged 102 commits into from
Oct 23, 2023

Conversation

yarnabrina
Copy link
Collaborator

@yarnabrina yarnabrina commented Sep 24, 2023

Fixes typos in forecasting module.

Also useful for diagnosing #5304.

Depends on #5304

@yarnabrina yarnabrina marked this pull request as ready for review September 24, 2023 15:51
@yarnabrina
Copy link
Collaborator Author

Ready for review. See checks to note that only forecasting tests were run because of change in relevant sub-directory.

Notes: failure in CI status is due to the fact I cancelled existing CI workflows to trigger new one quicker.

* origin/main:
  [MNT] Auto format pyproject (sktime#5425)
…plit-ci

* origin/validate-extras-workflow: (33 commits)
  shorted workflow and job names
  removed unnecessary exclusion
  Revert "remove workflows temporarily"
  Revert "remove older python versions temporarily"
  add python 3.12 bound for tbats
  add python 3.12 bound for pmdarima
  add python 3.12 bound for stumpy
  add python 3.12 bound for pyod
  add python 3.12 bound for tsfresh
  add python 3.12 bound for tslearn
  add python 3.12 bound for tensorflow
  add python 3.12 bound for statsforecast
  add python 3.12 bound for numba
  remove older python versions temporarily
  removed mrsqm from classification extra
  added python 3.11 bound for esig
  reduce job matrix size
  support 3.12
  remove python bounds temporarily
  remove workflows temporarily
  ...
…recasting

* origin/split-ci: (35 commits)
  [MNT] Auto format pyproject (sktime#5425)
  shorted workflow and job names
  removed unnecessary exclusion
  Revert "remove workflows temporarily"
  Revert "remove older python versions temporarily"
  add python 3.12 bound for tbats
  add python 3.12 bound for pmdarima
  add python 3.12 bound for stumpy
  add python 3.12 bound for pyod
  add python 3.12 bound for tsfresh
  add python 3.12 bound for tslearn
  add python 3.12 bound for tensorflow
  add python 3.12 bound for statsforecast
  add python 3.12 bound for numba
  remove older python versions temporarily
  removed mrsqm from classification extra
  added python 3.11 bound for esig
  reduce job matrix size
  support 3.12
  support 3.12
  ...
…recasting

* origin/split-ci:
  format pyproject
…sting

* origin/main:
  [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395)
  [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459)
  [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304)
  [MNT] new CI workflow to test extras (sktime#5375)
  [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461)
  [BUG] [MNT] removed two recently added hooks (sktime#5453)
  [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
@fkiraly fkiraly changed the title [MNT] [DIAG] Test change in forecasting [MNT] fix typos in forecasting module Oct 22, 2023
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few changes left, look correct.

@yarnabrina yarnabrina merged commit 274af84 into sktime:main Oct 23, 2023
46 checks passed
@yarnabrina yarnabrina deleted the test-change-in-forecasting branch October 23, 2023 04:12
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 25, 2023
…heck

* origin/main:
  [ENH] Add tecator dataset for time series regression as `sktime` onboard dataset (sktime#5428)
  [MNT] fix typos in `forecasting` module (sktime#5314)
  [MNT] fix typos in `base` module (sktime#5313)
  [DOC] Programmatically fix (all) typos (sktime#5424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics diagnostic PR to run CI with a modification, e.g., pre-release of dependencies maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants