[MNT] added upper bound pycatch22<0.4.5 in transformations dependency set to avoid installation error on windows
#5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarnabrina
added
the
maintenance
yarnabrina
requested review from
achieveordie,
benHeid and
fkiraly
as code owners
fkiraly
changed the title
pycatch22<0.4.5 in transformations dependency set to avoid installation error on windows
yarnabrina
added a commit
that referenced
this pull request
Dec 31, 2023
#5638) Fixes #5559 (indirectly depends on #5670 for all tests to pass as part of #5639) This fixes few bugs (typos, possibly unreliable coverage, etc.) and added some minor enhancements in new CI. 1. fix main typo: sktime-component was using detect_components_with_extras which is undefined 2. split test_components into two separate workflows: 1. one to test individual components using dedicated extras and reuse defined actions 2. one to test all other components without extras using all_extras_pandas2 3. split long commands into multiple lines using YAML multiline strings (ref. https://yaml-multiline.info/) 4. skip duplicated testing of base as part of testing components without dedicated extras 5. remove coverage in partial tests 6. add coverage in full tests if missing 7. added validation of all_extras_pandas2 8. minor changes (mostly renaming) in some places The changes are tested in #5639 and as it can be seen in https://github.com/sktime/sktime/actions/runs/7339442367, both components with and without extras trigger sub-jobs as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts bound update by #5442, in line with #5434.