-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsfeatures adapter #968
tsfeatures adapter #968
Conversation
@mloning / @fkiraly - Some dependency issues with tsfeatures here.
(Also entropy is depreciated) I've raised this as an issue in tsfeatures but it might take a while till it's resolved. Another option is to create the individual features as series-to-primitives transformers as suggested by @fkiraly in #905 (comment) and then create a panel-to-dataframe from those. A complete checklist for the individual series to primitives transformers (copied from Combination of Forecast Methods by Feature-based Learning) would be:
|
Hey @ltsaprounis I'm not sure if the dependency issues have been resolved? Are you still thinking of finishing this PR? I may close this, of course you can always reopen if you want to pick it up again. |
@mloning - the maintainers solved the dependencies shortly after I raised the issue but I forgot to get back to it. I'm not planning to work on this in the near future so makes sense to close it. |
@fkiraly I'd like to pick this up if possible |
PS @AJarman, I see you´re helping out in |
All really did was implement croston inside a container, as it only had one parameter it wasn't a complicated implementation! I am still quite new to open source so working through 'first issues' at the moment, I've also applied to the mentorship program.a |
Hi @AJarman! Are you still working on this issue? Let me know if I can help in any way :) |
Reference Issues/PRs
Fixes #905
What does this implement/fix? Explain your changes.
Implementing a tsfeatures adapter for sktime.
Will be a panel-to-tabular transformer, similar to tsfresh and catch22
Does your contribution introduce a new dependency? If yes, which one?
Adding tsfeatures as a soft depeendency
What should a reviewer concentrate their feedback on?
Nothing yet, will update this section in the near future
Any other comments?
PR checklist
For all contributions
For new estimators