Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsfeatures adapter #968

Closed
wants to merge 2 commits into from
Closed

tsfeatures adapter #968

wants to merge 2 commits into from

Conversation

ltsaprounis
Copy link
Contributor

Reference Issues/PRs

Fixes #905

What does this implement/fix? Explain your changes.

Implementing a tsfeatures adapter for sktime.
Will be a panel-to-tabular transformer, similar to tsfresh and catch22

Does your contribution introduce a new dependency? If yes, which one?

Adding tsfeatures as a soft depeendency

What should a reviewer concentrate their feedback on?

Nothing yet, will update this section in the near future

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@TonyBagnall TonyBagnall added the module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing label Jun 26, 2021
@ltsaprounis
Copy link
Contributor Author

ltsaprounis commented Jun 30, 2021

@mloning / @fkiraly - Some dependency issues with tsfeatures here.
Looks like the requirements in tsfeatures are too strict:

arch==4.14
git+https://github.com/raphaelvallat/entropy@v0.1.1
pandas==1.0.5
scikit-learn==0.23.1
statsmodels==0.11.1
supersmoother==0.4

(Also entropy is depreciated)

I've raised this as an issue in tsfeatures but it might take a while till it's resolved. Another option is to create the individual features as series-to-primitives transformers as suggested by @fkiraly in #905 (comment) and then create a panel-to-dataframe from those.

A complete checklist for the individual series to primitives transformers (copied from Combination of Forecast Methods by Feature-based Learning) would be:

  • x_acf
  • x_acf10
  • diff1_acf1
  • diff1_acf10
  • diff2_acf1
  • diff2_acf10
  • seas_acf1
  • ARCH.LM
  • crossing_point
  • entropy
  • flat_spots
  • arch_acf
  • garch_acf
  • arch_r2
  • garch_r2
  • alpha
  • beta
  • hurst
  • lumpiness
  • nonlinearity
  • x_pacf5
  • diff1x_pacf5
  • diff2x_pacf5
  • seas_pacf
  • nperiods
  • seasonal_period
  • trend
  • spike
  • linearity
  • curvature
  • e_acf1
  • e_acf10
  • se
  • peak
  • trough
  • stability
  • hw_alpha
  • hw_beta
  • hw_gamma
  • unitroot_kpss
  • unitroot_pp
  • series_length

@mloning
Copy link
Contributor

mloning commented Dec 4, 2021

Hey @ltsaprounis I'm not sure if the dependency issues have been resolved? Are you still thinking of finishing this PR? I may close this, of course you can always reopen if you want to pick it up again.

@ltsaprounis
Copy link
Contributor Author

@mloning - the maintainers solved the dependencies shortly after I raised the issue but I forgot to get back to it. I'm not planning to work on this in the near future so makes sense to close it.

@AJarman
Copy link

AJarman commented Dec 19, 2021

@fkiraly I'd like to pick this up if possible

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 19, 2021

feel free to go ahead, @AJarman! Please post in the original issue #905, and have a look at the new transformers extension template. There´s also a rough tutorial for transformers, still work in progress, in this PR: #1705 (feedback is appreciated)

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 19, 2021

PS @AJarman, I see you´re helping out in pycaret with interval forecasts, so you may also be interested to contribute to work in sktime on interval and probabilistic forecasting?

@AJarman
Copy link

AJarman commented Dec 20, 2021

PS @AJarman, I see you´re helping out in pycaret with interval forecasts, so you may also be interested to contribute to work in sktime on interval and probabilistic forecasting?

All really did was implement croston inside a container, as it only had one parameter it wasn't a complicated implementation! I am still quite new to open source so working through 'first issues' at the moment, I've also applied to the mentorship program.a

@AzulGarza
Copy link
Contributor

AzulGarza commented Mar 10, 2022

Hi @AJarman! Are you still working on this issue? Let me know if I can help in any way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] tsfeatures in sktime
6 participants