Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix joint name prefix in spotkinovaeus #87

Merged
merged 1 commit into from Nov 17, 2021
Merged

Fix joint name prefix in spotkinovaeus #87

merged 1 commit into from Nov 17, 2021

Conversation

mqcmd196
Copy link
Collaborator

For fixing jsk-ros-pkg/jsk_demos#1347 (comment) .
Fixing cannot find method error in go-grasp function.

@mqcmd196 mqcmd196 mentioned this pull request Nov 17, 2021
Open
@mqcmd196
Copy link
Collaborator Author

@708yamaguchi Can you check if you have time?

@tkmtnt7000 tkmtnt7000 merged commit 7a6abf5 into sktometometo:develop/spot Nov 17, 2021
@mqcmd196 mqcmd196 deleted the fix_eus_grasp branch November 17, 2021 06:01
@sktometometo
Copy link
Owner

@mqcmd196 Please add package name tag to the front of your commit message like [spotkinovaeus] hogehoge so that rebase or cherry-picking is easy

@sktometometo
Copy link
Owner

And please split your commit as small as possible.
Since PRs for kinova and spotkinova is different, I need split this commit manually.

@mqcmd196
Copy link
Collaborator Author

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkmtnt7000 tkmtnt7000 Awaiting requested review from tkmtnt7000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mqcmd196 @sktometometo @tkmtnt7000