Attachments added to the end of the message (backward compatible version) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-n-g
changed the title
skulltech
approved these changes
Jan 7, 2021
|
Thank you so much for the contribution @s-n-g . I'm getting back after about one and a half years but better late than never I guess!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you haven't yet had a look at the other PR, this one would be much better, since it provides backward compatibility
Changed attach to
If data is not provided, filename should be full path to a file, which will be placed at the end of the file. If data is provided, the behavior remains as it was up until now
Still relevant to #4