Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding self.attach_late(path, mimetype=None) #7

Closed
wants to merge 3 commits into from
Closed

Adding self.attach_late(path, mimetype=None) #7

wants to merge 3 commits into from

Conversation

s-n-g
Copy link
Contributor

@s-n-g s-n-g commented Aug 27, 2019

This way the attachments will be added to the message
when self.prepare() is executed (late), effectively
placing the attachments at the end of the message

Relevant to #4

@s-n-g
Adding self.attach_late(path, mimetype=None)
df68d60 
This way the attachments will be added to the message
when self.prepare() is executed (late), effectively
placing the attachments at the end of the message
@s-n-g s-n-g mentioned this pull request Aug 27, 2019
Closed
@skulltech
Copy link
Owner

Thank you so much for the PR @s-n-g !! I'll take a proper look at it shortly.

@skulltech skulltech self-requested a review July 8, 2020 09:38
@skulltech skulltech self-assigned this Jul 8, 2020
@skulltech
Copy link
Owner

Pull-request #8 was accepted instead of this, as @s-n-g themself suggested, as that's essentially a better version of the same code.

@skulltech skulltech closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skulltech skulltech Awaiting requested review from skulltech

Assignees

@skulltech skulltech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-n-g @skulltech