Refactor time module and fix its tests #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further info re Travis build failure: A local branch merging this PR and #1232 builds and passes all tests: % git checkout -b test-1232-and-1233 use-terser
% git merge --no-edit --no-ff refactor-time-module-and-fix-its-tests
% rm -r node_modules
% npm install && npm run build && npm run test
[...]
test/unit/[...]
Passed: 462 Failed: 0
test/unit3/[...]
Passed: 938 Failed: 0 |
s-cork
approved these changes
Nov 26, 2020
For consistency with how time.timezone is computed.
Code taken from existing localtime_f() and mod.gmtime(), changed slightly to take arg saying whether to treat input as UTC. squash! from_seconds(): Add JS helper function
Also fix copy/paste typo so gmtime() uses correct function name in its call to pyCheckArgsLen().
Test functions
asctime
ctime
gmtime
localtime
mktime
strftime
strptime
with regard to raising errors if an incorrect number of arguments
passed.
Currently, the tests fail for:
asctime
ctime
mktime
This will be addressed in the next commit.
Fixes remaining tests added previously.
bennorth
force-pushed
the
refactor-time-module-and-fix-its-tests
branch
from
1812eea
to
450f442
Compare
|
This pr has caused a bug - |
|
Apologies. I'll have a look at that now. |
|
I've just created #1251. Sorry for overlooking this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the aside in #1231 regarding the failed
TimeTestCase.test_strftimetest.If I'm reading it right, Skulpt's implementation of
time.timezoneuses the offset as of 2002. I'm in Ireland and the history of its civil timekeeping means that its timezone offset was different in 1970 compared to 2002. It's likely that developers in other timezones weren't seeing this failure. This PR updates the test to use a moment in 2002, for consistency with howtimezoneis computed. I've checked it under timezonesEurope/Dublin,America/Denver,Europe/Istanbul.This PR also extracts a function from near-duplicated code between Skulpt's
localtime()andgmtime()implementations, and fixes a minor typo.