Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility to new numpy scipy and numexpr versions #281

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

skuschel
Copy link
Owner

@skuschel skuschel commented Jul 8, 2024

  • Scipy 1.14.0 removed deprecated scipy.integrate.trapz and scipy.integrate.simps functions
  • numexpr introduced (in version 2.9?) sanity check rules, which result in invalid control character errors if ignored.
  • numpy 2.0 changed array_ufunc such that axis=None is possible.
  • numpy 2.0 has removed np.asfarray

@skuschel skuschel added bug Something isn't working (as expected) housekeeping / code cleanup does not change the functionality labels Jul 8, 2024
@skuschel skuschel self-assigned this Jul 8, 2024
in the kwargs, the argument axis=None may be give when reducing all
axis. Handle this case.
otherwise numexpr raises an error "expression xxx has forbidden control characters"
it has been removed in numpy 2.0
python 3.9 on github has trouble installing numexpr.
@skuschel skuschel added compatibility bug caused by change in other packages and removed bug Something isn't working (as expected) labels Jul 8, 2024
@skuschel skuschel changed the title WIP: various bugfixes update compatibility to new numpy scipy and numexpr versions Jul 8, 2024
@skuschel skuschel changed the title update compatibility to new numpy scipy and numexpr versions compatibility to new numpy scipy and numexpr versions Jul 8, 2024
@skuschel skuschel merged commit a304e73 into master Jul 8, 2024
10 checks passed
@skuschel skuschel added the incompatible change This change may create incompatibilities label Jul 9, 2024
@skuschel
Copy link
Owner Author

skuschel commented Jul 9, 2024

The interface change in scipy 1.14 (renaming scipy.integrate.trapz to scipy.integrate.trapezoid and scipy.integrate.simps to scipy.integrate.simpson) and ALSO changing the signature of the function is not compatible to versions prior to scipy 1.6.
If compatibiliyt to older scipy versions is required, please open a bug and link this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility bug caused by change in other packages housekeeping / code cleanup does not change the functionality incompatible change This change may create incompatibilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant