Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS-4467 GUARD-3085-Extract-ParallelProcessExtensions-From-ThreeDCart-Lib #16

Conversation

maxim-saltanov-skuvault
Copy link
Contributor

@maxim-saltanov-skuvault maxim-saltanov-skuvault commented Sep 6, 2023

Description

Tickets: RLS-4467 GUARD-3085

Summary: pointed to ParallelProcessExtensions in the Integrations.Core

Background

In the related PR I extracted methods from ThreeDCart into Integrations.Core library. In the current PR we could remove them and point to Integrations.Core

About these changes

  • removed ParallelProcessExtensions methods and unit tests
  • pointed to Integrations.Core instead

PR Readiness Checklist

  • I have updated all relevant configuration
  • Followed development conventions to the best of my ability
  • Code is documented, particularly public interfaces and hard-to-understand areas
  • Tests are updated / added and all pass
  • Performed a self-review of my own code
  • Acceptance criterias are confirmed by testing changes in UI (or another appropriate way)
  • Confluence documentation is updated, if needed
  • New code does not generate new warnings

maxim-skuvault
maxim-skuvault previously approved these changes Sep 6, 2023
SShumer
SShumer previously approved these changes Sep 7, 2023
Victoria-SV
Victoria-SV previously approved these changes Sep 11, 2023
…s into GUARD-3085-Extract-ParallelProcessExtensions-From-ThreeDCart-Lib
@maxim-saltanov-skuvault maxim-saltanov-skuvault dismissed stale reviews from Victoria-SV, SShumer, and maxim-skuvault September 13, 2023 06:33

The merge-base changed after approval.

@maxim-saltanov-skuvault maxim-saltanov-skuvault merged commit 961dac8 into master Sep 14, 2023
@maxim-saltanov-skuvault maxim-saltanov-skuvault deleted the GUARD-3085-Extract-ParallelProcessExtensions-From-ThreeDCart-Lib branch September 14, 2023 05:26
@skuvault-bot skuvault-bot bot changed the title GUARD-3085-Extract-ParallelProcessExtensions-From-ThreeDCart-Lib RLS-4467 GUARD-3085-Extract-ParallelProcessExtensions-From-ThreeDCart-Lib Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants