Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: run skeleton tests after normal tests in the same build. #330

Merged
merged 1 commit into from
Oct 21, 2020
Merged

GitHub Actions: run skeleton tests after normal tests in the same build. #330

merged 1 commit into from
Oct 21, 2020

Conversation

skvadrik
Copy link
Owner

No description provided.

@skvadrik skvadrik mentioned this pull request Oct 20, 2020
Merged
@skvadrik skvadrik force-pushed the skvadrik-ci branch 2 times, most recently from 2331d44 to ff0be64 Compare October 20, 2020 22:53
sergeyklay
sergeyklay approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about "${{ matrix.skeleton }}" == true. However, if I'm wrong and it actually works as you expect - great!

@sergeyklay
Copy link
Collaborator

Just for your info: There is an ability to cancel builds in case of force-push

image

@skvadrik
Copy link
Owner Author

Just for your info: There is an ability to cancel builds in case of force-push

Ah, I was wondering about that. I hoped it would auto-cancel, but apparently not (or maybe they get cancelled, but still show in the UI). :)

@skvadrik
Copy link
Owner Author

I'm not sure about "${{ matrix.skeleton }}" == true

Seems to work as expected (skeleton build runs skeleton tests, non-skeleton one doesn't). Are you worries about the usual shell things like empty variable on the left hand side, or not quoting true? Maybe it should be "x${{ matrix.skeleton }}" == "xtrue".

@sergeyklay
Copy link
Collaborator

Maybe it should be "x${{ matrix.skeleton }}" == "xtrue".

Yeah, I usually prefer something like this. But, if everything is OK, then great!

@skvadrik skvadrik merged commit 2b363b9 into master Oct 21, 2020
@skvadrik skvadrik deleted the skvadrik-ci branch October 21, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skvadrik @sergeyklay