Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should cache the zone lookups. #6

Closed
skx opened this issue Jun 18, 2014 · 0 comments
Closed

We should cache the zone lookups. #6

skx opened this issue Jun 18, 2014 · 0 comments

Comments

@skx
Copy link
Owner

skx commented Jun 18, 2014

Currently we pull the complete zone out, to get the most current records, for the /edit/ operation.

By contrast at /home/ we just use Net::DNS. At the time I considered this too expensive to lookup constantly, but Net::DNS isn't responsive enough.

Suggestion:

  • Drop the use of Net::DNS.
  • Update DHCP::Records to cache, in Redis, the return value of getRecords - with TTL of 60 seconds.

Invalidate on hits to /edit/ + /set obviously. (Or wait for cache to expire via TTL, if the cache-time is the same as the zone..?)
skx added a commit that referenced this issue Jun 18, 2014
@skx
Drop usage of Net::DNS.
92e9985 
  The /home page now uses the Amazon API to get the current value
 of the DNS records.

  This updates #6 - although caching is still missing.
@skx skx closed this as completed in 2e7fef4 Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skx