Ask for Location Perms enabled #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaydeetay Please review. Thanks! |
jaydeetay
requested changes
Apr 28, 2019
| setUpAnalytics(versionName); | ||
|
|
||
| performFeatureCheck(); | ||
| private static final String TAG = MiscUtil.getTag(StardroidApplication.class); |
There was a problem hiding this comment.
Sorry - looks like you've done a big reformatting here. Please don't do that - it makes the change history harder to understand and can make merges more difficult. Doing a one off refactor to reformat is sometimes OK if a file is badly formatted, but it's best not to mix it up with functionality changes.
There was a problem hiding this comment.
@jaydeetay i have only reformatted the code using ctrl+alt+L. Nothing much.
There was a problem hiding this comment.
@jaydeetay I understood what you were talking about. Changes made 👍
|
@jaydeetay Now this can be merged, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269
Run the unit tests with
gradlew app:connectedGmsDebugAndroidTestto make sure you didn't break anything (with an emulator running or phone connected)If you have multiple commits please combine them into one commit by squashing them.