Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #381

Merged
merged 8 commits into from Nov 1, 2020
Merged

Code cleanup #381

merged 8 commits into from Nov 1, 2020

Conversation

TacoTheDank
Copy link
Contributor

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

  • If you have multiple commits please combine them into one commit by squashing them. (Your end)

Felt like doing this.

Copy link
Member

@jaydeetay jaydeetay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. Just a couple of places where the formatting has gone awry but otherwise LG.

@jaydeetay jaydeetay merged commit 24128ec into sky-map-team:master Nov 1, 2020
@TacoTheDank TacoTheDank deleted the code-cleanup branch November 5, 2020 15:23
marcocipriani01 pushed a commit to marcocipriani01/Telescope.Touch that referenced this pull request Mar 17, 2021
* Optimize imports

* Lint: Data flow issues

* Lint: Java 5 migration

* Lint: Java 8 migration

* Lint: Integer division in floating-point context

* Lint: Performance improvements

* Lint: Control flow issues

* Lint: Code style issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants