New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #381
Merged
Merged
Code cleanup #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeetay
reviewed
Oct 29, 2020
app/src/main/java/com/google/android/stardroid/control/TransitioningCompositeClock.java
Outdated
Show resolved
Hide resolved
jaydeetay
reviewed
Oct 29, 2020
app/src/main/java/com/google/android/stardroid/util/TimeUtil.java
Outdated
Show resolved
Hide resolved
jaydeetay
requested changes
Oct 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup. Just a couple of places where the formatting has gone awry but otherwise LG.
jaydeetay
approved these changes
Nov 1, 2020
marcocipriani01
pushed a commit
to marcocipriani01/Telescope.Touch
that referenced
this pull request
Mar 17, 2021
* Optimize imports * Lint: Data flow issues * Lint: Java 5 migration * Lint: Java 8 migration * Lint: Integer division in floating-point context * Lint: Performance improvements * Lint: Control flow issues * Lint: Code style issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
gradlew app:connectedGmsDebugAndroidTest
to make sure you didn't break anything (with an emulator running or phone connected)If you have multiple commits please combine them into one commit by squashing them. (Your end)
Felt like doing this.