Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CI, run style checks before unit tests #114

Closed
capelastegui opened this issue Feb 26, 2019 · 0 comments
Closed

In CI, run style checks before unit tests #114

capelastegui opened this issue Feb 26, 2019 · 0 comments

Comments

@capelastegui
Copy link
Contributor

Some CI builds pass all tests (which take several minutes), and then fail due to some code style issues. It would probably be better to have the style checks run first.

In travis.yml, change this:

script:
  - coverage run -m unittest discover
  - pycodestyle ./ --ignore=E402,W

to this:

script:
  - pycodestyle ./ --ignore=E402,W
  - coverage run -m unittest discover
capelastegui added a commit that referenced this issue Mar 5, 2019
capelastegui added a commit that referenced this issue Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant