-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/windows pty #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dmsgpty is working on win 10
This reverts commit 739c755.
4199bd4
to
edea07c
Compare
Everything is working on cmd , but the
|
This one is solved via |
logs.txt is the log of |
The hosts are stuck in a loop without a timeout. Also in this
|
Addressed in the ceb1204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and is working well on windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Everything work as well as possible.
Fixes skycoin/skywire#778
Prequisites:
Changes:
How to test this PR:
Run it on windows 10 / windows server 2019 with
Conpty
support (on by default since late 2018). No support on win server 2016 and below, neither does win 8.1 and below.Have redis binary installed and available from your
%PATH%
Currently supports running dmsgpty-cli from powershell only, Instruction:
make build-windows
or manually.Once all those is setup, open yet another powershell tab / window and do:
If all is well, you should be able to do local pty:
Screen.Recording.2021-06-21.at.09.52.51.mov
or
dmsgpty-ui
:To stop the integration environment, do:
TODO:
.ps1
script for integration test on windows, the same way it does for *nix.sc query afunix
to test your windows support)Edit: