-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build #779
Windows build #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start
For additional info on my comment on issue #778 Also tried to build this PR on windows and got this output: |
@4rchim3d3s : the build instruction is here => skycoin/dmsg#83 (comment) |
Thanks, I followed the instructions and instead of And now got this:
|
@4rchim3d3s : I cannot reproduce. Please follow the guide:
|
@alexadhy I retried it on desktop.
$ go mod vendor -v
go: downloading github.com/songgao/water v0.0.0-20200317203138-2b4b6d7c09d8
go: downloading github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635
go: extracting github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635
go: extracting github.com/songgao/water v0.0.0-20200317203138-2b4b6d7c09d8
go: downloading github.com/creack/pty v1.1.11
go: extracting github.com/creack/pty v1.1.11
go: downloading github.com/mmcloughlin/avo v0.0.0-20200523190732-4439b6b2c061
go: extracting github.com/mmcloughlin/avo v0.0.0-20200523190732-4439b6b2c061
go: downloading golang.org/x/tools v0.1.0
go: extracting golang.org/x/tools v0.1.0
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading golang.org/x/mod v0.4.2
go: extracting golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: extracting golang.org/x/mod v0.4.2
github.com/skycoin/skywire/cmd/apps/skychat imports
embed: malformed module path "embed": missing dot in first path element
github.com/skycoin/skywire/cmd/apps/skychat imports
io/fs: malformed module path "io/fs": missing dot in first path element And then with $ go build -o ./skywire-visor.exe ./cmd/skywire-visor/
build github.com/skycoin/skywire/cmd/skywire-visor: cannot load embed: malformed module path "embed": missing dot in first path element Guess I will just wait until it works as I don't know golang and how to import modules :) If you wish to I can try again someday but I don't want to make trouble because of my impatience :) |
@4rchim3d3s I think you need to upgrade your golang version, you need go version 1.16.x to make it work |
@alexadhy I am sorry. That was the problem. Now skywire and vpn app build without problem |
func attachTTY(_ *exec.Cmd) { | ||
// not used for Windows | ||
} | ||
|
||
return | ||
func (c *Context) ignoreSignals() { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these blank functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholder function, to match the unix equivalent
7d70c0b
to
f222d9d
Compare
347f774
to
b74d4d0
Compare
I test it on test env. One point I see that was wrong for me:
Full log: log.txt |
Getting nil pointer dereference in vpn-client when trying to connect to |
This was because |
Did you run
make format && make check
? yesFixes #778
Changes:
TODO:
cmdutil
function such ascmdutil.SignalContext
should probably be fixed ondmsg
repostdio
package for example) in this draft PR, probably refactor it later once it is testedHow to test this PR:
NEEDS