Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build curl lib in release mode #67

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Build curl lib in release mode #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ee89a1
use CMAKE_BUILD_TYPE o debug as default value if none specified ref #66
stdevAlDen May 26, 2019
29c7110
build lib curl in release mode ref #66
stdevAlDen May 26, 2019
d304b68
update changeslog ref #66
stdevAlDen May 26, 2019
bf51ecd
refs #66 - Minor fix in CHANGELOG
olemis Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Added

- Be able to set a build type for lib curl.
- Export functions in Skycoin 0.25.1 core API's
- `skyapi` C client for Skycoin node REST at `lib/curl`.
- Support for building `libskycoin` on ARM and 32 / 64 bits.
Expand Down
6 changes: 5 additions & 1 deletion lib/curl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ project(CGenerator)
#set(CMAKE_C_VISIBILITY_PRESET default)
#set(CMAKE_CXX_VISIBILITY_PRESET default)
#set(CMAKE_VISIBILITY_INLINES_HIDDEN OFF)
set(CMAKE_BUILD_TYPE Debug)
if(NOT CMAKE_BUILD_TYPE)
set(CMAKE_BUILD_TYPE Debug)
endif(NOT CMAKE_BUILD_TYPE)

set(pkgName "skyapi")

Expand Down Expand Up @@ -80,6 +82,8 @@ target_link_libraries(${pkgName} ${CURL_LIBRARIES})
#install library to destination
install(TARGETS ${pkgName} DESTINATION ${CMAKE_INSTALL_PREFIX})

unset(CMAKE_BUILD_TYPE CACHE)

# Setting file variables to null
#set(SRCS "")
#set(HDRS "")
Expand Down
2 changes: 1 addition & 1 deletion lib/curl/install_lib_curl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ cd build
#echo "brew ls --verbose curl"
#brew ls --verbose curl
# for normal install use following command
cmake -DCMAKE_VERBOSE_MAKEFILE=ON ..
cmake -DCMAKE_BUILD_TYPE=Release ..
grep -R object_convertToJSON ../../
make
sudo make install
Expand Down