-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passphrase compatibility to the hw wallet #2218
base: develop
Are you sure you want to change the base?
Conversation
Will not be merged until later; this is scheduled for v2 wallet firmware |
|
||
import { HwPassphraseDialogComponent } from './hw-passphrase-dialog.component'; | ||
|
||
describe('HwPassphraseDialogComponent', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
describe('HwPassphraseDialogComponent', () => { | |
describe("HwPassphraseDialogComponent", () => { |
@@ -0,0 +1,14 @@ | |||
import { Component } from '@angular/core'; | |||
import { MatDialogRef } from '@angular/material/dialog'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { MatDialogRef } from '@angular/material/dialog'; | |
import { MatDialogRef } from "@angular/material/dialog"; |
|
||
@Component({ | ||
selector: 'app-hw-passphrase-help-dialog', | ||
templateUrl: './hw-passphrase-help-dialog.component.html', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
templateUrl: './hw-passphrase-help-dialog.component.html', | |
templateUrl: "./hw-passphrase-help-dialog.component.html", |
import { MatDialogRef } from '@angular/material/dialog'; | ||
|
||
@Component({ | ||
selector: 'app-hw-passphrase-help-dialog', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
selector: 'app-hw-passphrase-help-dialog', | |
selector: "app-hw-passphrase-help-dialog", |
@@ -12,6 +12,7 @@ import { HwChangePinDialogComponent } from '../hw-change-pin-dialog/hw-change-pi | |||
import { HwRestoreSeedDialogComponent } from '../hw-restore-seed-dialog/hw-restore-seed-dialog.component'; | |||
import { Observable } from 'rxjs/Observable'; | |||
import { HwDialogBaseComponent } from '../hw-dialog-base.component'; | |||
import { HwPassphraseActivationDialogComponent } from '../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { HwPassphraseActivationDialogComponent } from '../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component'; | |
import { HwPassphraseActivationDialogComponent } from "../hw-passphrase-activation-dialog/hw-passphrase-activation-dialog.component"; |
import { HwWalletService, OperationResults } from '../../../../services/hw-wallet.service'; | ||
import { ChildHwDialogParams } from '../hw-options-dialog/hw-options-dialog.component'; | ||
import { HwDialogBaseComponent } from '../hw-dialog-base.component'; | ||
import { HwPassphraseHelpDialogComponent } from '../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { HwPassphraseHelpDialogComponent } from '../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component'; | |
import { HwPassphraseHelpDialogComponent } from "../hw-passphrase-help-dialog/hw-passphrase-help-dialog.component"; |
|
||
import { HwPassphraseActivationDialogComponent } from './hw-passphrase-activation-dialog.component'; | ||
|
||
describe('HwPassphraseActivationDialogComponent', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
describe('HwPassphraseActivationDialogComponent', () => { | |
describe("HwPassphraseActivationDialogComponent", () => { |
import { MatDialogRef, MAT_DIALOG_DATA, MatDialog, MatDialogConfig } from '@angular/material/dialog'; | ||
import { HwWalletService, OperationResults } from '../../../../services/hw-wallet.service'; | ||
import { ChildHwDialogParams } from '../hw-options-dialog/hw-options-dialog.component'; | ||
import { HwDialogBaseComponent } from '../hw-dialog-base.component'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { HwDialogBaseComponent } from '../hw-dialog-base.component'; | |
import { HwDialogBaseComponent } from "../hw-dialog-base.component"; |
|
||
console.log("Hardware wallet passphrase requested"); | ||
if (win) { | ||
win.webContents.send('hwPassphraseRequested'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
win.webContents.send('hwPassphraseRequested'); | |
win.webContents.send("hwPassphraseRequested"); |
@@ -0,0 +1,60 @@ | |||
import { Component, Inject } from '@angular/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { Component, Inject } from '@angular/core'; | |
import { Component, Inject } from "@angular/core"; |
fixture.detectChanges(); | ||
}); | ||
|
||
it('should be created', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
it('should be created', () => { | |
it("should be created", () => { |
@@ -0,0 +1,25 @@ | |||
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; | |
import { async, ComponentFixture, TestBed } from "@angular/core/testing"; |
@@ -0,0 +1,44 @@ | |||
import { Component, OnInit, OnDestroy } from '@angular/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { Component, OnInit, OnDestroy } from '@angular/core'; | |
import { Component, OnInit, OnDestroy } from "@angular/core"; |
|
||
@Component({ | ||
selector: 'app-hw-passphrase-dialog', | ||
templateUrl: './hw-passphrase-dialog.component.html', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
templateUrl: './hw-passphrase-dialog.component.html', | |
templateUrl: "./hw-passphrase-dialog.component.html", |
@Component({ | ||
selector: 'app-hw-passphrase-dialog', | ||
templateUrl: './hw-passphrase-dialog.component.html', | ||
styleUrls: ['./hw-passphrase-dialog.component.scss'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
styleUrls: ['./hw-passphrase-dialog.component.scss'], | |
styleUrls: ["./hw-passphrase-dialog.component.scss"], |
@@ -0,0 +1,44 @@ | |||
import { Component, OnInit, OnDestroy } from '@angular/core'; | |||
import { FormBuilder, Validators, FormGroup } from '@angular/forms'; | |||
import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog'; | |
import { MatDialogRef, MatDialog, MatDialogConfig } from "@angular/material/dialog"; |
fixture.detectChanges(); | ||
}); | ||
|
||
it('should be created', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
it('should be created', () => { | |
it("should be created", () => { |
} | ||
|
||
@Component({ | ||
selector: 'app-hw-passphrase-activation-dialog', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
selector: 'app-hw-passphrase-activation-dialog', | |
selector: "app-hw-passphrase-activation-dialog", |
|
||
openHelp() { | ||
this.dialog.open(HwPassphraseHelpDialogComponent, <MatDialogConfig> { | ||
width: '450px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
width: '450px', | |
width: "450px", |
@@ -0,0 +1,44 @@ | |||
import { Component, OnInit, OnDestroy } from '@angular/core'; | |||
import { FormBuilder, Validators, FormGroup } from '@angular/forms'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { FormBuilder, Validators, FormGroup } from '@angular/forms'; | |
import { FormBuilder, Validators, FormGroup } from "@angular/forms"; |
import { Component, OnInit, OnDestroy } from '@angular/core'; | ||
import { FormBuilder, Validators, FormGroup } from '@angular/forms'; | ||
import { MatDialogRef, MatDialog, MatDialogConfig } from '@angular/material/dialog'; | ||
import { HwWalletService } from '../../../../services/hw-wallet.service'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
import { HwWalletService } from '../../../../services/hw-wallet.service'; | |
import { HwWalletService } from "../../../../services/hw-wallet.service"; |
|
||
ngOnInit() { | ||
this.form = this.formBuilder.group({ | ||
passphrase: ['', Validators.required], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
passphrase: ['', Validators.required], | |
passphrase: ["", Validators.required], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Changes:
This PR includes many texts, so it would be good to check them with some care, since there may be errors.
Does this change need to mentioned in CHANGELOG.md?