Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data races in router #237

Closed
Darkren opened this issue Mar 22, 2020 · 2 comments
Closed

Data races in router #237

Darkren opened this issue Mar 22, 2020 · 2 comments
Assignees
@Darkren
Labels
bug Something isn't working

Comments

@Darkren
Copy link
Contributor

Darkren commented Mar 22, 2020

Describe the bug
Found data race on make test:

==================
WARNING: DATA RACE
Read at 0x00c0003f4558 by goroutine 275:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).sendKeepAlive()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:379 +0xcd
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).keepAliveLoop()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:370 +0x2e6

Previous write at 0x00c0003f4558 by goroutine 291:
  [failed to restore the stack]

Goroutine 275 (running) created at:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.NewRouteGroup()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:126 +0x777
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).saveRouteGroupRules()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:375 +0x4dd
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:234 +0xb17
  github.com/SkycoinProject/skywire-mainnet/pkg/router.Test_router_DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router_test.go:97 +0xf58
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c0003f4570 by goroutine 275:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).sendKeepAlive()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:379 +0x4a3
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).keepAliveLoop()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:370 +0x2e6

Previous write at 0x00c0003f4570 by goroutine 291:
  [failed to restore the stack]

Goroutine 275 (running) created at:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.NewRouteGroup()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:126 +0x777
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).saveRouteGroupRules()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:375 +0x4dd
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:234 +0xb17
  github.com/SkycoinProject/skywire-mainnet/pkg/router.Test_router_DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router_test.go:97 +0xf58
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c0002fe0e0 by goroutine 275:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).sendKeepAlive()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:385 +0x1d3
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).keepAliveLoop()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:370 +0x2e6

Previous write at 0x00c0002fe0e0 by goroutine 291:
  [failed to restore the stack]

Goroutine 275 (running) created at:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.NewRouteGroup()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:126 +0x777
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).saveRouteGroupRules()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:375 +0x4dd
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:234 +0xb17
  github.com/SkycoinProject/skywire-mainnet/pkg/router.Test_router_DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router_test.go:97 +0xf58
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c0004bb640 by goroutine 275:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).sendKeepAlive()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:386 +0x249
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*RouteGroup).keepAliveLoop()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:370 +0x2e6

Previous write at 0x00c0004bb640 by goroutine 291:
  [failed to restore the stack]

Goroutine 275 (running) created at:
  github.com/SkycoinProject/skywire-mainnet/pkg/router.NewRouteGroup()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/route_group.go:126 +0x777
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).saveRouteGroupRules()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:375 +0x4dd
  github.com/SkycoinProject/skywire-mainnet/pkg/router.(*router).DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router.go:234 +0xb17
  github.com/SkycoinProject/skywire-mainnet/pkg/router.Test_router_DialRoutes()
      /Users/darkrengarius/go/src/github.com/SkycoinPro/skywire-mainnet/pkg/router/router_test.go:97 +0xf58
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199
==================
Found 4 data race(s)
FAIL	github.com/SkycoinProject/skywire-mainnet/pkg/router	74.099s
@Darkren Darkren added the bug Something isn't working label Mar 22, 2020
@Darkren
Copy link
Contributor Author

Darkren commented Apr 23, 2020

Bump, still persists, just encountered

@Darkren Darkren self-assigned this Apr 23, 2020
@Darkren Darkren mentioned this issue Apr 23, 2020
Merged
@jdknives
Copy link
Member

Likely fixed by #278

jdknives pushed a commit that referenced this issue Oct 19, 2020
@Darkren
Fix router data race (#237)
1267030 
Former-commit-id: 3141315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darkren Darkren

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Darkren @jdknives