Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN apps #278

Merged
merged 106 commits into from
Apr 30, 2020
Merged

VPN apps #278

merged 106 commits into from
Apr 30, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Mar 30, 2020 •
edited

Did you run make format && make check?

Fixes #100 , #237

Changes:

  • Implemented VPN server
  • Implemented VPN client
  • Modified apps to accept custom envs on start
  • Fixed datarace in router

@Darkren Darkren marked this pull request as draft April 9, 2020 13:16
evanlinjin
evanlinjin reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job making this relatively easy to follow (considering what it is).

I'm not going to pretend I know how TUN/STUN is meant to work, but I've listed my concerns below.

go.mod Show resolved Hide resolved
cmd/apps/vpn-client/vpn-client.go Outdated Show resolved Hide resolved
cmd/apps/vpn-client/vpn-client.go Outdated Show resolved Hide resolved
internal/vpn/ip_generator.go Show resolved Hide resolved
internal/vpn/os_linux.go Outdated Show resolved Hide resolved
@jdknives jdknives mentioned this pull request Apr 29, 2020
Closed
8 tasks
@Darkren Darkren merged commit 2b52938 into skycoin:develop Apr 30, 2020
This was referenced Apr 30, 2020
Closed
Closed
jdknives pushed a commit that referenced this pull request Oct 19, 2020
@Darkren
Merge pull request #278 from Darkren/feature/vpn
dbe90a7 
VPN apps

Former-commit-id: 2b52938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin left review comments

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Darkren @evanlinjin @nkryuchkov