Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HypervisorUI dmsg tab #407

Closed
jdknives opened this issue Jun 15, 2020 · 3 comments
Closed

HypervisorUI dmsg tab #407

jdknives opened this issue Jun 15, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request frontend

Comments

@jdknives
Copy link
Member

jdknives commented Jun 15, 2020

Feature description

@skycoin-main requested that we add a dmsg tab to the landing page of the hypervisor UI. This tab should display:

The visors connected to the hypervisor (same list as in the Visor list tab). Below each visor, the UI should display the PubKey of the dmsg.Server used to connect to the visor as well as the Ping roundtrip time.

Requires: https://github.com/SkycoinProject/dmsg/issues/110

@jdknives
Copy link
Member Author

@Senyoret1 Evan implemented the backend for this in #415 . Would you mind integrating that with the Hypervisor frontend?

@Senyoret1
Copy link
Contributor

@jdknives I already checked the changes made to the backend and I was wondering if a new tab is really needed. The current visor list could be modiffied to show the new data and it is also possible to add a button for hidding the extra data. This would avoid having 2 lists wich are basically the same, which could be confusing

@jdknives
Copy link
Member Author

jdknives commented Jul 1, 2020

@Senyoret1 good point. It does not have to be a separate tab if you are able to integrate this data in the visor list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

No branches or pull requests

3 participants