Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypervisor dmsg tab. #415

Merged
merged 15 commits into from
Jun 30, 2020
Merged

Hypervisor dmsg tab. #415

merged 15 commits into from
Jun 30, 2020

Conversation

evanlinjin
Copy link
Contributor

@evanlinjin evanlinjin commented Jun 22, 2020

Fixes #407

Changes:

  • Added /api/dmsg endpoint to Hypervisor which tracks dmsgctrl connections.
  • Visors now serves dmsgctrl streams.
  • Fix segmentation fault due to incorrect address resolver init logic in snet.

How to test this PR:

  • Start interactive testing environment with:
    • skywire-services@feature/use-promutil
    • dmsg@develop
  • Navigate t0 https://localhost:8000/api/dmsg
  • Attempts can be made to start/stop different visors and see changes to the output given by https://localhost:8000/api/dmsg. Note that some changes are not shown immediately.

@evanlinjin evanlinjin marked this pull request as ready for review June 29, 2020 07:08
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

cmd/hypervisor/commands/root.go Outdated Show resolved Hide resolved
pkg/hypervisor/dmsg_tracker.go Outdated Show resolved Hide resolved
evanlinjin and others added 4 commits June 30, 2020 12:35
Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com>
* Use reflect to obtain function name for hypervisor.DmsgTrackerManager logs.
@evanlinjin evanlinjin merged commit a15a789 into skycoin:develop Jun 30, 2020
@jdknives jdknives mentioned this pull request Jun 30, 2020
jdknives pushed a commit that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants