Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMSG info to the manager #427

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Add DMSG info to the manager #427

merged 5 commits into from
Jul 10, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #407

Changes:

  • Now the visor list shows the DMSG server public key and the ping.
  • As the new data makes the list harder to read, it is hidden by default and can be added to the list with a button.
  • The DMSG server info was also added to the visor info in the visor details page.

How to test this PR:
Check the visor list and visor details page in the Skywire Manager.

@jdknives
Copy link
Member

jdknives commented Jul 7, 2020

@Senyoret1 good job. This looks fine and works as expected. The only change I would make is to display the Ping in some human readable unit. I think milliseconds might make sense.

@Senyoret1
Copy link
Contributor Author

The last commits include the following changes:

  • Now the ping is shown in ms.
  • The conflicts with the lastest version of the develop branch were solved.
  • A small change was made to a style to make it work like other styles in the develop branch.

@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

  • The node list with dmsg info was moved to another tab.

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jdknives jdknives merged commit f496ad8 into skycoin:develop Jul 10, 2020
jdknives added a commit that referenced this pull request Oct 19, 2020
Add DMSG info to the manager

Former-commit-id: f496ad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants