Use retrier from the dmsg package netutil #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the retrier used from internal netutil to dmsgnetutil in order to use a retrier from a single place.
This commit deletes the retrier code from the internal netutil package and the places that it was used now use retrier from dmsgnetutil. Going forward the retrier from dmsg repos netutil package will be used.
This commit changes the max backoff of retrier in client in package utclient and autoconnect and client in package servicedisc to zero. It is set to zero to give it no max backoff just like it's previous iteration.
This commit removes the warning log from the retrier func of app discovery as a warning log is used in the retrier and this one is no longer needed.
mrpalide
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?yes
Fixes #1040
Changes:
How to test this PR:
//replace github.com/skycoin/dmsg => ../dmsgin go mod an runmake dep; make build./skywire-cli config gen -dir./skywire-visor -c skywire-config.jsonCtrl+Cand see if there are no retrier warn logs while closingNeeds:
#dmsg-162