Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypervisor improvements #126

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Hypervisor improvements #126

merged 5 commits into from
Jan 24, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Jan 23, 2020 •
edited
Loading

Closes #75
Closes #92

Changes:

  1. Fix the It is not possible to make operations related to the routes with the API #75 bug
  2. Refactor the hypervisor module
  3. Fix Make /exec endpoint consistent with others #92

How to test this PR:

  1. Follow the instructions from It is not possible to make operations related to the routes with the API #75
  2. Run hypervisor tests and linter

Darkren
Darkren approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

jdknives
jdknives approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@nkryuchkov nkryuchkov changed the title Hypervisor improvements [WIP] Hypervisor improvements Jan 24, 2020
@nkryuchkov nkryuchkov changed the title [WIP] Hypervisor improvements Hypervisor improvements Jan 24, 2020
jdknives
jdknives approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@jdknives jdknives merged commit d11e0f5 into skycoin:milestone2 Jan 24, 2020
This was referenced Jan 24, 2020
Closed
Closed
@nkryuchkov nkryuchkov deleted the fix/hypervisor-bug-and-refactor branch March 13, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren approved these changes

@jdknives jdknives jdknives approved these changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

@Kifen Kifen Awaiting requested review from Kifen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkryuchkov @Darkren @jdknives