Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite keep alive loop #134

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Fix infinite keep alive loop #134

merged 4 commits into from
Jan 28, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Jan 28, 2020 •
edited
Loading

Partially fixes #95

Changes:

  • Added correct exit from keep-alive loop on route group closing

@Darkren Darkren added bug Something isn't working milestone2 labels Jan 28, 2020
@Darkren
Change condition to stop keep-alive loop
d537a89 
Earlier loop was being stopped when the route group got closed. Now loop stops
when remote gets closed. It's more correct, since we don't need to send keep-alive
packets to the closed remote, it will cause unnecessary network errors, resulting
in a lot of logs which don't carry any useful information
@Darkren Darkren changed the title [WIP] Fix infinite keep alive loop Fix infinite keep alive loop Jan 28, 2020
evanlinjin
evanlinjin approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good work.

Kifen
Kifen approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@Kifen Kifen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@evanlinjin
Copy link
Contributor

The test that is failing in Travis is fixed in #133

@jdknives jdknives closed this Jan 28, 2020
@jdknives jdknives reopened this Jan 28, 2020
@jdknives jdknives merged commit f91d15d into skycoin:milestone2 Jan 28, 2020
@Darkren Darkren deleted the fix/infinite-keep-alive-loop branch February 7, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Kifen Kifen Kifen approved these changes

@nkryuchkov nkryuchkov Awaiting requested review from nkryuchkov

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[M2] Check behavior of route groups
4 participants
@Darkren @evanlinjin @Kifen @jdknives