Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve route group logging, fix route group closing procedure #135

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Improve route group logging, fix route group closing procedure #135

merged 3 commits into from
Jan 29, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Jan 28, 2020

Fixes #95

Changes:

  • Route group closing procedure was fixed. Now it doesn't get interrupted in case any of the intermediay nodes is down
  • Improved logging a bit, logs are more informative now

@Darkren Darkren added enhancement New feature or request milestone2 labels Jan 28, 2020
nkryuchkov
nkryuchkov approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jdknives
Copy link
Member

@Darkren could you please fix the linter and pull the changes? I think that may fix the tests.

@jdknives jdknives merged commit ed51af1 into skycoin:milestone2 Jan 29, 2020
@Darkren Darkren deleted the fix/improve-route-group-logging branch February 7, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

@Kifen Kifen Awaiting requested review from Kifen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[M2] Check behavior of route groups
3 participants
@Darkren @jdknives @nkryuchkov