Add app arg cli subcommand #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thic commit contains the new subcommand arg which is used to change various args of the apps. This subcommand setAppAutostartCmd which was previously directly under app is now also moved under arg. The other commands contains setAppAutostartCmd, setAppKillswitchCmd and setAppSecureCmd whcih take the app name and on/off as arguemnts. The subcommands setAppPasscodeCmd and setAppNetworkInterfaceCmd take app name and a string as their args and have a special arg named remove that removes the arg from the said app.
jdknives
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Add new subcommand arg to visor app Thic commit contains the new subcommand arg which is used to change various args of the apps. This subcommand setAppAutostartCmd which was previously directly under app is now also moved under arg. The other commands contains setAppAutostartCmd, setAppKillswitchCmd and setAppSecureCmd whcih take the app name and on/off as arguemnts. The subcommands setAppPasscodeCmd and setAppNetworkInterfaceCmd take app name and a string as their args and have a special arg named remove that removes the arg from the said app. * Minor change * Add changelog * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #
Changes:
argtoskywire-cli visor appautoconnectfromskywire-cli visor apptoskywire-cli visor app argHow to test this PR:
./skywire-visor -c skywire-config.json./skywire-cli visor app arg passcode vpn-client testand check the config./skywire-cli visor app arg passcode vpn-client removeand check the config./skywire-cli visor app arg netifc vpn-server testand check the config./skywire-cli visor app arg netifc vpn-server removeand check the config./skywire-cli visor app arg autostart vpn-server trueand check the config./skywire-cli visor app arg killswitch vpn-server trueand check the config./skywire-cli visor app arg secure vpn-server trueand check the config./skywire-cli visor app arg autostart vpn-server falseand check the config./skywire-cli visor app arg killswitch vpn-server falseand check the config./skywire-cli visor app arg secure vpn-server falseand check the config