Setup node metrics. #412
Merged
Setup node metrics. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanlinjin binaries are still there. |
Darkren
suggested changes
Jun 22, 2020
| } | ||
|
|
||
| // Execute executes root CLI command. | ||
| func Execute() { | ||
| if err := rootCmd.Execute(); err != nil { | ||
| log.Fatal(err) | ||
| panic(err) |
There was a problem hiding this comment.
Why do you think this change is necessary?
There was a problem hiding this comment.
log.Fatal logs the error and then panics. However, when a cobra.Command fails, it already logs the error. So we only need to panic here.
pkg/setup/setupmetrics/metrics.go
Outdated
| m.activeRequests.Inc() | ||
|
|
||
| return func(rules *routing.EdgeRules, err *error) { | ||
| var successStr string |
There was a problem hiding this comment.
we may simplify this part a bit with something like this:
successStr := "true"
if *err != nil {
successStr = "false"
}
btw, is it neccessary to have interface pointer in the func signature, wouldn't just error be enough here?
There was a problem hiding this comment.
That code looks cleaner. I'll get it done.
The pointer of an error is needed. We need to get the pointer of the error, as the error value will change.
jdknives
added a commit
that referenced
this pull request
Oct 19, 2020
Setup node metrics. Former-commit-id: 36a3530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
Changes:
How to test this PR:
setup-nodewith flag-m :2121http://localhost:2121/metrics