Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to update all visors #414

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Allow to update all visors #414

merged 2 commits into from
Jun 23, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #408

Changes:

  • A button for updating all visors was added to the left bar in the visor list.

How to test this PR:
Use the button in the left bar in the visor list.

NOTE: the hipervisor API only returns an answer to the update request after finishing the procedure. This causes the hypervisor to return an error response if the internet connection is not fast enough to download everything before the timeout. Related issue: #413

@jdknives
Copy link
Member

@Senyoret1 The button does not work for me. I can update the visor manually when clicking Update after accessing the visor, but there is no update found when using the Update all.

Bildschirmfoto 2020-06-22 um 17 48 39

Bildschirmfoto 2020-06-22 um 17 48 48

@Senyoret1
Copy link
Contributor Author

@jdknives Thanks for noticing that, it should be working now. I also fixed a potential problem with offline visors.

@jdknives
Copy link
Member

@Senyoret1 good job. The update mechanism works smoothly for the scenarios I tested.

@jdknives jdknives merged commit 2cfe63a into skycoin:develop Jun 23, 2020
jdknives added a commit that referenced this pull request Oct 19, 2020
Allow to update all visors

Former-commit-id: 2cfe63a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants