Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the update procedure #453

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Improvements for the update procedure #453

merged 5 commits into from
Aug 11, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:
A new modal window for updating the visors was added. Is has several advantages:

  • Now the updating code is centraliced, which removes repeated code, improves the separation of concerns and makes the code more maintanable.
  • The new component is able to parse the progress responses returned by the backend and shows a much better UI:
    uw
  • The new component takes into account a lot of posible cases which were not previously being correctly managed, like the nodes being updated when opening the modal window, even if only some of them are being updated.
    Other changes are:
  • The Spanish translation was updated.
  • A new proxy rule for connection to the ws and wss endpoint with the Angular dev server was added.

How to test this PR:
Use the update options in the visor list and the visor details pages.

Known problem:

If you use the option for updating all visors, in the visor list, the UI will call the visors/${nodeKey}/update/ws API endpoint for all of them and will show progress for all of them. However, all visors will show the same progress, but the command window of just one visor will show progress.

This means that when calling the visors/${nodeKey}/update/ws API endpoint several times for updating several visors, only one visor will be updated and all web sockets will show the progress of that single visor, not mater for which visor the web socket was created.

This can be tested using make integration-run-generic.

cc @nkryuchkov

@Senyoret1
Copy link
Contributor Author

The problem described in the initial msg was solved in https://github.com/Senyoret1/skywire-mainnet/pull/2 and merged into the branch used for this PR. @jdknives It includes Go code, so maybe you would like to take a look.

There is also a new commit by @nkryuchkov including changes to the vendored dependencies, as the Travis tests were failing.

Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine. Great job!

static/skywire-manager-src/proxy.config.json Outdated Show resolved Hide resolved
@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

  • The app protocol version was removed from the right bar, as requested a few days ago.
  • A small problem with the proxy configuration was fixed.

@nkryuchkov nkryuchkov requested a review from jdknives July 31, 2020 15:41
@jdknives
Copy link
Member

jdknives commented Aug 4, 2020

@Senyoret1 good job. UI looks much cleaner. Please fix the conflicts and we can merge this.

@Senyoret1
Copy link
Contributor Author

I force pushed changes to remove 024fd39 from the PR, for solving most of the conflicts as the changes were already added in #454 .

@jdknives jdknives merged commit 52f5865 into skycoin:develop Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants