Fix/check empty password

pkg/app/appcommon/proc_config.go

@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"strings"
 
 	"github.com/google/uuid"
 	"github.com/skycoin/dmsg/cipher"
@@ -106,6 +107,48 @@ func (c *ProcConfig) Envs() []string {
 	return append(c.ProcEnvs, fmt.Sprintf(format, EnvProcConfig, string(c.encodeJSON())))
 }
 
+// ContainsFlag checks if a given flag has been passed to the ProcConfig.
+func (c *ProcConfig) ContainsFlag(flag string) bool {
+	for _, arg := range c.ProcArgs {
+		if argEqualsFlag(arg, flag) {
+			return true
+		}
+	}
+	return false
+}
+
+// ArgVal returns the value associated in ProcConfig with a given flag.
+func (c *ProcConfig) ArgVal(flag string) string {
+	for idx, arg := range c.ProcArgs {
+		if argEqualsFlag(arg, flag) && idx+1 < len(c.ProcArgs) {
+			return c.ProcArgs[idx+1]
+		}
+	}
+
+	return ""
+}
+
+func argEqualsFlag(arg, flag string) bool {
+	arg = strings.TrimSpace(arg)
+
+	// strip prefixed '-'s.
+	for {
+		if len(arg) < 1 {
+			return false
+		}
+		if arg[0] == '-' {
+			arg = arg[1:]
+			continue
+		}
+		break
+	}
+
+	// strip anything after (inclusive) of '='.
+	arg = strings.Split(arg, "=")[0]
+
+	return arg == flag
+}
+
 func (c *ProcConfig) encodeJSON() []byte {
 	b, err := json.Marshal(c)
 	if err != nil {

pkg/app/appdisc/factory.go

@@ -1,7 +1,6 @@
 package appdisc
 
 import (
-	"strings"
 	"time"
 
 	"github.com/sirupsen/logrus"
@@ -65,7 +64,7 @@ func (f *Factory) AppUpdater(conf appcommon.ProcConfig) (Updater, bool) {
 	log := f.Log.WithField("appName", conf.AppName)
 
 	// Do not update in proxy discovery if passcode-protected.
-	if containsFlag(conf.ProcArgs, "passcode") {
+	if conf.ContainsFlag("passcode") && conf.ArgVal("passcode") != "" {
 		return &emptyUpdater{}, false
 	}
 
@@ -94,33 +93,3 @@ func (f *Factory) AppUpdater(conf appcommon.ProcConfig) (Updater, bool) {
 		return &emptyUpdater{}, false
 	}
 }
-
-func containsFlag(args []string, flag string) bool {
-	for _, arg := range args {
-		if argEqualsFlag(arg, flag) {
-			return true
-		}
-	}
-	return false
-}
-
-func argEqualsFlag(arg, flag string) bool {
-	arg = strings.TrimSpace(arg)
-
-	// strip prefixed '-'s.
-	for {
-		if len(arg) < 1 {
-			return false
-		}
-		if arg[0] == '-' {
-			arg = arg[1:]
-			continue
-		}
-		break
-	}
-
-	// strip anything after (inclusive) of '='.
-	arg = strings.Split(arg, "=")[0]
-
-	return arg == flag
-}