Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transport labels #686

Merged
merged 6 commits into from
May 12, 2021

Conversation

i-hate-nicknames
Copy link
Contributor

Did you run make format && make check?

Fixes #662

Changes:

  • Add labels to transport, based on who added the transport

How to test this PR:

pkg/transport/entry.go Outdated Show resolved Hide resolved
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start so far. Just a small change and obviously there is some logic missing but this can wait until we can finally merge the rest of the code.

@i-hate-nicknames i-hate-nicknames changed the title WIP Feature/transport labels Feature/transport labels May 12, 2021
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdknives jdknives merged commit c616f21 into skycoin:develop May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants