Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool flag config representation #695

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Fix bool flag config representation #695

merged 5 commits into from
Feb 24, 2021

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Feb 24, 2021

Did you run make format && make check?

Fixes #691

Changes:

  • All boolean flags that we support are now represented in format of --flag_name=value in the app args.

jdknives
jdknives approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just one suggestion.

pkg/visor/visorconfig/v1.go Show resolved Hide resolved
@jdknives
Copy link
Member

log.txt

We are also running into a panic when updating the secure mode on an empty VPN server arg list.

@jdknives jdknives merged commit ee865e4 into skycoin:develop Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkren @jdknives