Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add router related config to the manager #729

Merged
merged 11 commits into from
Jun 3, 2021
Merged

Add router related config to the manager #729

merged 11 commits into from
Jun 3, 2021

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • Now the min and max hops are shown in the right bar of the visor details page. Also, under the data there is a button for being able to change the values.

How to test this PR:
Enter to the visor details page and check the data in the right bar. For changing the values, press the Change configuration button.

Note: the PR will be finished after the API endpoints for getting and setting the data are added.

@Senyoret1
Copy link
Contributor Author

Senyoret1 commented Jun 3, 2021

The last commits include the following changes:

  • Now the UI shows the current config and is able to change it.
  • The max hops options were removed.
  • A help text was added.
  • The changes made in Add min hops manipulation endpoint #780 were added to this PR, as are nedded for the changes to work and for the Travis tests.

Now this PR should be ready.

@Senyoret1 Senyoret1 changed the title [WIP] Add router related config to the manager Add router related config to the manager Jun 3, 2021
@jdknives jdknives merged commit 38f7339 into skycoin:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants