-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min hops manipulation endpoint #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should add the CLI commands just to be consistent. I cant see a use for it effectively so we may get rid of it. But also does not hurt to have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 comments about the implementation:
- It would be good if the
GET /api/visors/{pk}/summary
API endpoint returns the data, that way the UI would not have to make an additional API call, which would make the UI a bit slower. - Is there also a max hops configuration? If that is the case, it sould be added to the API too.
|
275542c
to
b2d3432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I implemented the changes in #729, thanks 👍
Did you run
make format && make check
? yesFixes #770
Related to:
Changes:
min_hops
endpoint to the http API and rpc one (@jdknives @Senyoret1 not sure about the latter, since there'sroute-finder
)How to test this PR:
/visors/{pk}/min-hops
endpoint (POST
andGET
) like:skywire-cli visor route get-min-hops
andskywire-cli visor route set-min-hops <some_number>