Fix a bug in the app list #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the last commits, the changes made in #780 were added to this PR, as are nedded for the Travis tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?The go code was not changed.
npm run lintandnpm run buildwere used.Changes:
Currently, if a visor has no arguments for the skychat app, it is not possible to use the Skywire manager for seeing the app list, as there is an error. This PR solves that problem.
When a visor does not have a port explicitly defined for the skychat app in the config file, the link shown in the Skywire manager for showing the skychat UI does not work. This PR solves that problem.
How to test this PR:
Use the Skywire manager to open a visor without any argument for the skychat app and open the app list, it should be displayed normally. Also, press the icon in the right part of the table to open the skychat UI, it should be openned normally.