Fix/shutdown race #897
Merged
Fix/shutdown race #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mutex lock to DeleteEntry in servicedisc to fix the datarace
The comment was updated to reflect the changes.
Stop() of service updater is called from two places so stopOnce sync.Once was added as we only need to stop it once.
Debug logs added to DeleteEntry() and RegisterEntry() in servicedisc.
jdknives
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?yes
Fixes #890
Changes:
DeleteEntryand updated mutex comment.stopOnceforStop()in service updater to fix this.DeleteEntryandRegisterEntry.How to test this PR:
./skywire-visor skywire-config.jsonCtrl+C