Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health endpoint: 3 states => connecting, healthy, and unhealthy #933

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

alexadhy
Copy link
Contributor

@alexadhy alexadhy commented Oct 14, 2021

Did you run make format && make check? yes

Fixes #

Changes:

  • On initialize, the visor will return "connecting" as its health status.
  • On failure updating visor uptime, it will return "unhealthy"
  • On success, it will return "healthy"

How to test this PR:

  • Run visor
  • curl -sL http://localhost:8000/api/visors/<PK>/summary | jq -r .health

@jdknives jdknives merged commit 98b82ed into skycoin:develop Oct 15, 2021
@alexadhy alexadhy deleted the fix/3states branch November 23, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants