Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?The go code was not changed.
npm run lint
andnpm run build
were used.Fixes #923
Changes:
transport.public_autoconnect
setting was added to the UI.How to test this PR:
transport.public_autoconnect
setting: open the visor details page and use the option in the Transports Info section, in the bar at the right.NOTE: while testing with the standard test enviroment, it was posible to add and remove persistent transports in the
0348c...
visor (visorB), but there was a problem with the024ec...
and031b8...
visors (visorA and visorC). More specifically, theGET /api/visors/{pk}/persistent-transports
API endpoint returns{"error":"rpc: can't find method app-visor.GetPersistentTransports"}
. Not sure about the cause of the error, but may need atention.