Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the manager UI #924

Merged
merged 8 commits into from
Oct 16, 2021
Merged

Improvements for the manager UI #924

merged 8 commits into from
Oct 16, 2021

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #923

Changes:

  • The manager was adapted to work with the new health info format.
  • The option for making a transport persistent was fixed.
  • The option for configuring the transport.public_autoconnect setting was added to the UI.

How to test this PR:

  • For checking the new node health info: check the right bar in the visor details page, the Health Info section should work well. Also, in the visor list, the color dots at the left should work well.
  • For the persistent transport option: press the star at the left of a transport in the transport list, in the visor details page.
  • For the transport.public_autoconnect setting: open the visor details page and use the option in the Transports Info section, in the bar at the right.

NOTE: while testing with the standard test enviroment, it was posible to add and remove persistent transports in the 0348c... visor (visorB), but there was a problem with the 024ec... and 031b8... visors (visorA and visorC). More specifically, the GET /api/visors/{pk}/persistent-transports API endpoint returns {"error":"rpc: can't find method app-visor.GetPersistentTransports"}. Not sure about the cause of the error, but may need atention.

@ersonp ersonp mentioned this pull request Oct 13, 2021
@ersonp
Copy link
Contributor

ersonp commented Oct 14, 2021

  • public_autoconnect does not work on remote visor via RPC
  • Visors takes around 30 seconds to turn green (maybe an issue on my side or from the backend, someone else needs to test it too)
  • When Uptime tracker is in disconnected state the color is yellow inside visor details. I think it should either be connecting and yellow or disconnected and red.

@ersonp ersonp mentioned this pull request Oct 14, 2021
@Senyoret1
Copy link
Contributor Author

The last commits solve the conflicts and removes unused code. Waiting for #933 for making other changes

@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

@jdknives jdknives merged commit 9473271 into skycoin:develop Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants