Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onTouchListener option to the overlay popup #204

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

JoePaul
Copy link
Contributor

@JoePaul JoePaul commented Jul 13, 2021

Thanks for a great lib, I needed to introduce one small addition to the lib for one of my projects.

I added the possibility to add an onTouchListener to the overlay making it possible to pass MotionEvents other than ACTION_OUTSIDE down to the anchor.

Hopefully this is something that is of interest to add to the lib.

@JoePaul JoePaul requested a review from skydoves as a code owner July 13, 2021 12:30
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contributions!

@skydoves skydoves merged commit 9ed8062 into skydoves:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants