fix(xml): use parent attibute only for styles (PR #1815)

skylot · Apr 10, 2023 · 1ad6527 · 1ad6527
1 parent 0421ad8
commit 1ad6527
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/jadx-core/src/main/java/jadx/core/xmlgen/ResXmlGen.java b/jadx-core/src/main/java/jadx/core/xmlgen/ResXmlGen.java
@@ -123,14 +123,15 @@ private void addValue(ICodeWriter cw, ResourceEntry ri) {
 				if (formatValue != null) {
 					cw.add("\" format=\"").add(formatValue);
 				}
-				cw.add("\"");
 			} else {
-				cw.add(ri.getKeyName()).add('\"');
+				cw.add(ri.getKeyName());
 			}
-			cw.add(" parent=\"");
-			if (ri.getParentRef() != 0) {
-				String parent = vp.decodeValue(TYPE_REFERENCE, ri.getParentRef());
-				cw.add(parent);
+			if (ri.getTypeName().equals("style") || ri.getParentRef() != 0) {
+				cw.add("\" parent=\"");
+				if (ri.getParentRef() != 0) {
+					String parent = vp.decodeValue(TYPE_REFERENCE, ri.getParentRef());
+					cw.add(parent);
+				}
 			}
 			cw.add("\">");