fix: remove invalid chars from class names (#488)

jadx-core/src/main/java/jadx/core/deobf/NameMapper.java

@@ -126,7 +126,7 @@ public static boolean isAllCharsPrintable(String str) {
 	 * </ul><p>
 	 */
 	public static String removeInvalidCharsMiddle(String name) {
-		if (isValidIdentifier(name) && isAllCharsPrintable(name)) {
+		if (isValidIdentifier(name)) {
 			return name;
 		}
 		int len = name.length();

jadx-core/src/main/java/jadx/core/dex/visitors/RenameVisitor.java

@@ -92,10 +92,11 @@ private String fixClsShortName(String clsName) {
 		if (firstChar == '$') {
 			return 'C' + NameMapper.removeInvalidCharsMiddle(clsName);
 		}
-		if (!NameMapper.isValidIdentifier(clsName)) {
-			return 'C' + clsName;
+		String cleanClsName = NameMapper.removeInvalidChars(clsName, "C");
+		if (!NameMapper.isValidIdentifier(cleanClsName)) {
+			return 'C' + cleanClsName;
 		}
-		return NameMapper.removeInvalidChars(clsName, "C");
+		return cleanClsName;
 	}
 
 	private void checkFields(ClassNode cls) {

jadx-core/src/test/java/jadx/tests/integration/names/TestClassNameWithInvalidChar.java

@@ -0,0 +1,36 @@
+package jadx.tests.integration.names;
+
+import org.junit.jupiter.api.Test;
+
+import jadx.api.JadxDecompiler;
+import jadx.api.JadxInternalAccess;
+import jadx.core.dex.nodes.ClassNode;
+import jadx.core.dex.nodes.RootNode;
+import jadx.tests.api.SmaliTest;
+
+public class TestClassNameWithInvalidChar extends SmaliTest {
+	/*
+		public class do- {}
+		public class i-f {}
+	*/
+
+	@Test
+	public void test() {
+		JadxDecompiler d = loadSmaliFiles("names", "TestClassNameWithInvalidChar");
+		RootNode root = JadxInternalAccess.getRoot(d);
+		for (ClassNode cls : root.getClasses(false)) {
+			decompileAndCheckCls(d, cls);
+		}
+	}
+
+	@Test
+	public void testWithDeobfuscation() {
+		enableDeobfuscation();
+
+		JadxDecompiler d = loadSmaliFiles("names", "TestClassNameWithInvalidChar");
+		RootNode root = JadxInternalAccess.getRoot(d);
+		for (ClassNode cls : root.getClasses(false)) {
+			decompileAndCheckCls(d, cls);
+		}
+	}
+}

jadx-core/src/test/smali/names/TestClassNameWithInvalidChar/a.smali

@@ -0,0 +1,2 @@
+.class public Ldo-;
+.super Ljava/lang/Object;

jadx-core/src/test/smali/names/TestClassNameWithInvalidChar/b.smali

@@ -0,0 +1,2 @@
+.class public Li-f;
+.super Ljava/lang/Object;