Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]find usage should find the same method in super and interfaces #1349

Closed
cyqw opened this issue Jan 22, 2022 · 4 comments
Closed

[feature]find usage should find the same method in super and interfaces #1349

cyqw opened this issue Jan 22, 2022 · 4 comments
Labels
bug GUI Issues in jadx-gui module

Comments

@cyqw
Copy link
Contributor

cyqw commented Jan 22, 2022

Some class have override method from super or interfaces.
The caller function may use super or interface to call this method.
jadx.gui.ui.dialog.UsageDialog#collectUsageData should get UseIn of self and same method of super and interfaces.
@cyqw
Copy link
Contributor Author

cyqw commented Jan 22, 2022

I can get MethodNode of super and interfaces,how to get JavaMethod?

@skylot
Copy link
Owner

skylot commented Jan 23, 2022 •
edited

@cyqw this is indeed a bug, I totally forget about that, thanks!
An easier way is to use JavaMethod.getOverrideRelatedMethods() to get a list of all overridden methods from class hierarchy, and next merge all usages (JavaMethod.getUseIn()) from each method.
Do you willing to prepare PR? If yes, please assign this task for yourself.

@skylot skylot added bug GUI Issues in jadx-gui module and removed new feature labels Jan 23, 2022
@cyqw
Copy link
Contributor Author

cyqw commented Jan 23, 2022

I will try to prepare PR.

cyqw added a commit to cyqw/jadx that referenced this issue Jan 23, 2022
@cyqw
[feature]find usage should find the same method in super and interfaces
28a4c87 
skylot#1349
cyqw added a commit to cyqw/jadx that referenced this issue Jan 23, 2022
@cyqw
[feature]find usage should find the same method in super and interfaces
d69f3a6 
skylot#1349
cyqw added a commit to cyqw/jadx that referenced this issue Jan 23, 2022
@cyqw
[feature]find usage should find the same method in super and interfaces
c4aaf14 
skylot#1349
cyqw added a commit to cyqw/jadx that referenced this issue Jan 23, 2022
@cyqw
[feature]find usage should find the same method in super and interfaces
df562b5 
skylot#1349
skylot pushed a commit that referenced this issue Jan 23, 2022
@cyqw
fix(gui): find usage for overridden methods (#1349)(PR #1352)
be7e147
@skylot
Copy link
Owner

skylot commented Jan 23, 2022

Fixed in PR #1352 by @cyqw

@skylot skylot closed this as completed Jan 23, 2022
@anantshri anantshri mentioned this issue Feb 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GUI Issues in jadx-gui module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skylot @cyqw