Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deobfuscator creates references to not existing methods called in lambdas #452

Closed
bagipro opened this issue Feb 21, 2019 · 2 comments
Closed

Comments

@bagipro
Copy link
Collaborator

bagipro commented Feb 21, 2019

Hi, file com/yahoo/mobile/client/android/ecauction/ui/ECWebView.java

    /* renamed from: f */
    private void m4861f(java.lang.String str) {
        if (!this.f5342m) {
            java.util.HashMap hashMap = new java.util.HashMap();
            hashMap.put("x-from-app", "Android");
            com.yahoo.mobile.client.share.util.UiThreadUtils.m16124a(new com.yahoo.mobile.client.android.ecauction.ui.C1776-$$Lambda$ECWebView$ZL7XSN7Hbkj5ZISHsuytGuWvYM4(this, str, hashMap));
        }
    }

File com/yahoo/mobile/client/android/ecauction/ui/C1776-$$Lambda$ECWebView$ZL7XSN7Hbkj5ZISHsuytGuWvYM4.java

    public final void run() {
        this.f$0.m4844a(this.f$1, this.f$2);
    }

But method m4844a is never declared

APK: https://drive.google.com/file/d/1SMad5tO9zJevfaYYfNSzokLzpDkeHra9/view?usp=sharing

@skylot
Copy link
Owner

skylot commented Feb 22, 2019

I made a fix for this and similar cases, but still, there are can be other issues with synthetic methods. Looks like in this app many methods have a synthetic modifier and jadx trying to remove or inline them, so I made additional checks hope it will help.

@bagipro
Copy link
Collaborator Author

bagipro commented Feb 26, 2019

@skylot
Thanks! Seems to be fixed in all test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants