Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use of register instead of variable name #708

Closed
bagipro opened this issue Jul 11, 2019 · 2 comments
Closed

[core] Use of register instead of variable name #708

bagipro opened this issue Jul 11, 2019 · 2 comments
Labels
bug Core Issues in jadx-core module

Comments

@bagipro
Copy link
Collaborator

bagipro commented Jul 11, 2019

Checks before report

Describe error
File com/paypal/android/foundation/core/appsupport/ConfigImpl.java
No jadx errors are shown for this method

    private Set determineChangedValues(HashMap<String, Object> hashMap) {
        DesignByContract.require(validateConfiguration(hashMap), "Not a valid configuration.", new Object[0]);
        HashSet hashSet = new HashSet();
        synchronized (this.defaultValuesByPath) {
            for (String next : this.defaultValuesByPath.keySet()) {
                Object obj = hashMap.get(next);
                r5 = obj != null ? !getValueObject(next).equals(obj) : this.valuesByPath.get(next) != null;
                if (r5) { // <<<
                    hashSet.add(next);

APK: https://drive.google.com/file/d/1CSo_sZ71WsM3WvGw2VzG7xnkqpUO3GSJ/view?usp=sharing

@bagipro bagipro added bug Core Issues in jadx-core module labels Jul 11, 2019
@bagipro
Copy link
Collaborator Author

bagipro commented Jul 11, 2019

Similar in com/paypal/android/foundation/i18n/model/moneyvalue/LocaleCurrency.java

    public Currency getCurrencyForCode(String str) {
        r1 = null;
        for (Currency currency2 : getCurrency()) {
            if (currency2.getCode().equalsIgnoreCase(str)) {
                break;
            }
        }
        return currency2;
    }

@skylot
Copy link
Owner

skylot commented Jul 17, 2019

Both cases fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

2 participants