Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward navigation shortcut on macOS #1301

Merged
merged 2 commits into from Dec 6, 2021
Merged

fix: forward navigation shortcut on macOS #1301

merged 2 commits into from Dec 6, 2021

Conversation

Surendrajat
Copy link
Contributor

Description

This PR fixes the issue of nav.forward shortcut not working on macOS.

closes #1297

@skylot
Copy link
Owner

skylot commented Dec 5, 2021

@Surendrajat thanks! Looks good to me.
I will wait a couple of days for confirming that issue is fixed.
Hope @stAticasd (#1297) will check and reply.

@Surendrajat
Copy link
Contributor Author

@skylot yeah.. Waiting a bit will probably be better. I do hope that it doesn't break this for other OSes tho.

@stAticasd
Copy link

@Surendrajat Thank you!Looks good to me

@skylot
Copy link
Owner

skylot commented Dec 6, 2021

I do hope that it doesn't break this for other OSes tho.

@Surendrajat we can replace added true arg with SystemInfo.IS_MAC and not affect other OSes.

@skylot skylot merged commit 46eeb0b into skylot:master Dec 6, 2021
@Surendrajat Surendrajat deleted the fix-nav-forward-macos branch December 6, 2021 13:46
@Surendrajat Surendrajat restored the fix-nav-forward-macos branch December 6, 2021 13:47
@Surendrajat Surendrajat deleted the fix-nav-forward-macos branch December 6, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forward hot key seems not work in macos[feature]
3 participants