fix: filter invalid chars for gradle wrapper #1813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some special chars in the app name can cause conflicts when you try to add a gradle wrapper. In this pull request I filter all invalid chars before generating settings.gradle
Here is an example app containing invalid chars: https://xn--who-becomes-rich--84ns4b8gwbu6jza3u.apk.gold/
Steps to reproduce:
This issue can also easily be reproduced with new Android Studio project. Android Studio does not allow any special chars in the application name when the app is generated, but AndroidManifest.xml can be edited later like in my unit test.