Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AbstractCodeArea.java #2121

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Update AbstractCodeArea.java #2121

merged 3 commits into from
Mar 16, 2024

Conversation

zhongqingsong
Copy link
Contributor

Description

In general, we need data, not text in code. But now every time you copy the highlighted text, you copy the highlighted quotes as well. This often results in an extra need to delete the quotation marks around the sides, which is confusing.
Now when copying selected highlighted text, quotes are not copied in.

In general, we need data, not text in code. But now every time you copy the highlighted text, you copy the highlighted quotes as well. This often results in an extra need to delete the quotation marks around the sides, which is confusing.
Now when copying selected highlighted text, quotes are not copied in.
@zhongqingsong
Copy link
Contributor Author

Before this feature, in most scenarios, you wanted to use the copied data. Most of the operations must manually delete the quotation marks on both sides, which is troublesome to use.
For example, "test data from github"
1, if you need to search for this String in the search engine, you need to delete the quotation marks on both sides. The operation required is more cumbersome.
2, on the contrary, if you need double quotes, you must copy the content as a string in the code. Then the user only needs to enter double quotes, and the whole process is very smooth.
Compare the cost of using the two, and remove the copied highlighted text quotes, the benefit is greater.

The highlight copy function works even better. For example, after I copy the data, I can directly paste it into the browser to search, or I directly copy the values I need to the code, or I directly copy the results I get directly in Jadx search.
By removing the quotation marks, the convenience is greatly improved.

@skylot
Copy link
Owner

skylot commented Mar 16, 2024

@zhongqingsong thanks 👍
I moved code to upper method to make copy consistent with highlighting, also this will handle null result safely now.

@skylot skylot merged commit 8760b4d into skylot:master Mar 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants